| From cf3e204a1ca5442190018a317d9ec181b4639bd6 Mon Sep 17 00:00:00 2001 |
| From: Xin Long <lucien.xin@gmail.com> |
| Date: Fri, 13 Dec 2019 16:53:05 +0800 |
| Subject: netfilter: nft_tunnel: no need to call htons() when dumping ports |
| |
| From: Xin Long <lucien.xin@gmail.com> |
| |
| commit cf3e204a1ca5442190018a317d9ec181b4639bd6 upstream. |
| |
| info->key.tp_src and tp_dst are __be16, when using nla_put_be16() |
| to dump them, htons() is not needed, so remove it in this patch. |
| |
| Fixes: af308b94a2a4 ("netfilter: nf_tables: add tunnel support") |
| Signed-off-by: Xin Long <lucien.xin@gmail.com> |
| Reviewed-by: Simon Horman <simon.horman@netronome.com> |
| Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| net/netfilter/nft_tunnel.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/net/netfilter/nft_tunnel.c |
| +++ b/net/netfilter/nft_tunnel.c |
| @@ -505,8 +505,8 @@ static int nft_tunnel_opts_dump(struct s |
| static int nft_tunnel_ports_dump(struct sk_buff *skb, |
| struct ip_tunnel_info *info) |
| { |
| - if (nla_put_be16(skb, NFTA_TUNNEL_KEY_SPORT, htons(info->key.tp_src)) < 0 || |
| - nla_put_be16(skb, NFTA_TUNNEL_KEY_DPORT, htons(info->key.tp_dst)) < 0) |
| + if (nla_put_be16(skb, NFTA_TUNNEL_KEY_SPORT, info->key.tp_src) < 0 || |
| + nla_put_be16(skb, NFTA_TUNNEL_KEY_DPORT, info->key.tp_dst) < 0) |
| return -1; |
| |
| return 0; |
