| From 314e40444c7a6b64c3bcb30091f5c152284de788 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 7 Feb 2020 19:44:29 +0530 |
| Subject: RDMA/siw: Remove unwanted WARN_ON in siw_cm_llp_data_ready() |
| |
| From: Krishnamraju Eraparaju <krishna2@chelsio.com> |
| |
| [ Upstream commit 663218a3e715fd9339d143a3e10088316b180f4f ] |
| |
| Warnings like below can fill up the dmesg while disconnecting RDMA |
| connections. |
| Hence, remove the unwanted WARN_ON. |
| |
| WARNING: CPU: 6 PID: 0 at drivers/infiniband/sw/siw/siw_cm.c:1229 siw_cm_llp_data_ready+0xc1/0xd0 [siw] |
| RIP: 0010:siw_cm_llp_data_ready+0xc1/0xd0 [siw] |
| Call Trace: |
| <IRQ> |
| tcp_data_queue+0x226/0xb40 |
| tcp_rcv_established+0x220/0x620 |
| tcp_v4_do_rcv+0x12a/0x1e0 |
| tcp_v4_rcv+0xb05/0xc00 |
| ip_local_deliver_finish+0x69/0x210 |
| ip_local_deliver+0x6b/0xe0 |
| ip_rcv+0x273/0x362 |
| __netif_receive_skb_core+0xb35/0xc30 |
| netif_receive_skb_internal+0x3d/0xb0 |
| napi_gro_frags+0x13b/0x200 |
| t4_ethrx_handler+0x433/0x7d0 [cxgb4] |
| process_responses+0x318/0x580 [cxgb4] |
| napi_rx_handler+0x14/0x100 [cxgb4] |
| net_rx_action+0x149/0x3b0 |
| __do_softirq+0xe3/0x30a |
| irq_exit+0x100/0x110 |
| do_IRQ+0x7f/0xe0 |
| common_interrupt+0xf/0xf |
| </IRQ> |
| |
| Link: https://lore.kernel.org/r/20200207141429.27927-1-krishna2@chelsio.com |
| Signed-off-by: Krishnamraju Eraparaju <krishna2@chelsio.com> |
| Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/infiniband/sw/siw/siw_cm.c | 5 ++--- |
| 1 file changed, 2 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/infiniband/sw/siw/siw_cm.c b/drivers/infiniband/sw/siw/siw_cm.c |
| index 3bccfef40e7e1..ac86363ce1a24 100644 |
| --- a/drivers/infiniband/sw/siw/siw_cm.c |
| +++ b/drivers/infiniband/sw/siw/siw_cm.c |
| @@ -1225,10 +1225,9 @@ static void siw_cm_llp_data_ready(struct sock *sk) |
| read_lock(&sk->sk_callback_lock); |
| |
| cep = sk_to_cep(sk); |
| - if (!cep) { |
| - WARN_ON(1); |
| + if (!cep) |
| goto out; |
| - } |
| + |
| siw_dbg_cep(cep, "state: %d\n", cep->state); |
| |
| switch (cep->state) { |
| -- |
| 2.20.1 |
| |