| From 34e098a21b709f12c63f98eded0af87e28581eb0 Mon Sep 17 00:00:00 2001 |
| From: David S. Miller <davem@davemloft.net> |
| Date: Mon, 20 Sep 2010 15:40:35 -0700 |
| Subject: rose: Fix signedness issues wrt. digi count. |
| |
| |
| From: David S. Miller <davem@davemloft.net> |
| |
| [ Upstream commit 9828e6e6e3f19efcb476c567b9999891d051f52f ] |
| |
| Just use explicit casts, since we really can't change the |
| types of structures exported to userspace which have been |
| around for 15 years or so. |
| |
| Reported-by: Dan Rosenberg <dan.j.rosenberg@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| --- |
| net/rose/af_rose.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/net/rose/af_rose.c |
| +++ b/net/rose/af_rose.c |
| @@ -680,7 +680,7 @@ static int rose_bind(struct socket *sock |
| if (addr_len == sizeof(struct sockaddr_rose) && addr->srose_ndigis > 1) |
| return -EINVAL; |
| |
| - if (addr->srose_ndigis > ROSE_MAX_DIGIS) |
| + if ((unsigned int) addr->srose_ndigis > ROSE_MAX_DIGIS) |
| return -EINVAL; |
| |
| if ((dev = rose_dev_get(&addr->srose_addr)) == NULL) { |
| @@ -740,7 +740,7 @@ static int rose_connect(struct socket *s |
| if (addr_len == sizeof(struct sockaddr_rose) && addr->srose_ndigis > 1) |
| return -EINVAL; |
| |
| - if (addr->srose_ndigis > ROSE_MAX_DIGIS) |
| + if ((unsigned int) addr->srose_ndigis > ROSE_MAX_DIGIS) |
| return -EINVAL; |
| |
| /* Source + Destination digis should not exceed ROSE_MAX_DIGIS */ |
