| From cc7fce80229067890365c1ee196be5d304d36dea Mon Sep 17 00:00:00 2001 |
| From: Tomer Barletz <barletz@gmail.com> |
| Date: Tue, 4 Aug 2015 21:00:24 -0700 |
| Subject: mtd: blkdevs: fix switch-bool compilation warning |
| |
| From: Tomer Barletz <barletz@gmail.com> |
| |
| commit cc7fce80229067890365c1ee196be5d304d36dea upstream. |
| |
| With gcc 5.1 I get: |
| warning: switch condition has boolean value [-Wswitch-bool] |
| |
| Signed-off-by: Tomer Barletz <barletz@gmail.com> |
| Signed-off-by: Brian Norris <computersforpeace@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/mtd/mtd_blkdevs.c | 8 ++------ |
| 1 file changed, 2 insertions(+), 6 deletions(-) |
| |
| --- a/drivers/mtd/mtd_blkdevs.c |
| +++ b/drivers/mtd/mtd_blkdevs.c |
| @@ -97,14 +97,13 @@ static int do_blktrans_request(struct mt |
| if (req->cmd_flags & REQ_DISCARD) |
| return tr->discard(dev, block, nsect); |
| |
| - switch(rq_data_dir(req)) { |
| - case READ: |
| + if (rq_data_dir(req) == READ) { |
| for (; nsect > 0; nsect--, block++, buf += tr->blksize) |
| if (tr->readsect(dev, block, buf)) |
| return -EIO; |
| rq_flush_dcache_pages(req); |
| return 0; |
| - case WRITE: |
| + } else { |
| if (!tr->writesect) |
| return -EIO; |
| |
| @@ -113,9 +112,6 @@ static int do_blktrans_request(struct mt |
| if (tr->writesect(dev, block, buf)) |
| return -EIO; |
| return 0; |
| - default: |
| - printk(KERN_NOTICE "Unknown request %u\n", rq_data_dir(req)); |
| - return -EIO; |
| } |
| } |
| |
