| From e434e04110704eb91acfecbd0fb8ca8e2da9c29b Mon Sep 17 00:00:00 2001 |
| From: Arnd Bergmann <arnd@arndb.de> |
| Date: Fri, 29 Jan 2016 12:39:15 +0100 |
| Subject: net: tg3: avoid uninitialized variable warning |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| commit e434e04110704eb91acfecbd0fb8ca8e2da9c29b upstream. |
| |
| The tg3_set_eeprom() function correctly initializes the 'start' variable, |
| but gcc generates a false warning: |
| |
| drivers/net/ethernet/broadcom/tg3.c: In function 'tg3_set_eeprom': |
| drivers/net/ethernet/broadcom/tg3.c:12057:4: warning: 'start' may be used uninitialized in this function [-Wmaybe-uninitialized] |
| |
| I have not come up with a way to restructure the code in a way that |
| avoids the warning without making it less readable, so this adds an |
| initialization for the declaration to shut up that warning. |
| |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/net/ethernet/broadcom/tg3.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/ethernet/broadcom/tg3.c |
| +++ b/drivers/net/ethernet/broadcom/tg3.c |
| @@ -12021,7 +12021,7 @@ static int tg3_set_eeprom(struct net_dev |
| int ret; |
| u32 offset, len, b_offset, odd_len; |
| u8 *buf; |
| - __be32 start, end; |
| + __be32 start = 0, end; |
| |
| if (tg3_flag(tp, NO_NVRAM) || |
| eeprom->magic != TG3_EEPROM_MAGIC) |
