| From 1a016ab0f2132ce3fbd5f391ce6afa75d2d34c44 Mon Sep 17 00:00:00 2001 |
| From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Date: Mon, 3 Dec 2018 11:28:47 +0200 |
| Subject: usb: dwc3: trace: add missing break statement to make compiler happy |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| [ Upstream commit 54d48183d21e03f780053d7129312049cb5dd591 ] |
| |
| The missed break statement in the outer switch makes the code fall through |
| always and thus always same value will be printed. |
| |
| Besides that, compiler warns about missed fall through marker: |
| |
| drivers/usb/dwc3/./trace.h: In function ‘trace_raw_output_dwc3_log_trb’: |
| drivers/usb/dwc3/./trace.h:246:4: warning: this statement may fall through [-Wimplicit-fallthrough=] |
| switch (pcm) { |
| ^~~~~~ |
| |
| Add the missing break statement to work correctly without compilation |
| warnings. |
| |
| Fixes: fa8d965d736b ("usb: dwc3: trace: pretty print high-bandwidth transfers too") |
| Cc: Felipe Balbi <felipe.balbi@linux.intel.com> |
| Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/usb/dwc3/trace.h | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h |
| index f22714cce070..f27c5cbe285c 100644 |
| --- a/drivers/usb/dwc3/trace.h |
| +++ b/drivers/usb/dwc3/trace.h |
| @@ -251,9 +251,11 @@ DECLARE_EVENT_CLASS(dwc3_log_trb, |
| s = "2x "; |
| break; |
| case 3: |
| + default: |
| s = "3x "; |
| break; |
| } |
| + break; |
| default: |
| s = ""; |
| } s; }), |
| -- |
| 2.19.1 |
| |
