| From 987b782f4b5102eda71cabce4198619be02114bd Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 20 Feb 2024 00:11:19 +0100 |
| Subject: backlight: lm3630a: Initialize backlight_properties on init |
| |
| From: Luca Weiss <luca@z3ntu.xyz> |
| |
| [ Upstream commit ad9aeb0e3aa90ebdad5fabf9c21783740eb95907 ] |
| |
| The backlight_properties struct should be initialized to zero before |
| using, otherwise there will be some random values in the struct. |
| |
| Fixes: 0c2a665a648e ("backlight: add Backlight driver for lm3630 chip") |
| Signed-off-by: Luca Weiss <luca@z3ntu.xyz> |
| Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> |
| Link: https://lore.kernel.org/r/20240220-lm3630a-fixups-v1-1-9ca62f7e4a33@z3ntu.xyz |
| Signed-off-by: Lee Jones <lee@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/video/backlight/lm3630a_bl.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c |
| index f17e5a8860fa7..70f5ea5f210cc 100644 |
| --- a/drivers/video/backlight/lm3630a_bl.c |
| +++ b/drivers/video/backlight/lm3630a_bl.c |
| @@ -332,6 +332,7 @@ static int lm3630a_backlight_register(struct lm3630a_chip *pchip) |
| struct backlight_properties props; |
| struct lm3630a_platform_data *pdata = pchip->pdata; |
| |
| + memset(&props, 0, sizeof(struct backlight_properties)); |
| props.type = BACKLIGHT_RAW; |
| if (pdata->leda_ctrl != LM3630A_LEDA_DISABLE) { |
| props.brightness = pdata->leda_init_brt; |
| -- |
| 2.43.0 |
| |