| From 73d2786f288727ae2b8707f91a60e48d2eef811d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 28 Mar 2019 14:36:14 -0400 |
| Subject: media: dvbdev: remove double-unlock |
| |
| From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> |
| |
| [ Upstream commit 122d0e8dd050cc5dc3fb9e9b5f2dee3c5276ce35 ] |
| |
| As warned by smatch: |
| drivers/media/dvb-core/dvbdev.c: drivers/media/dvb-core/dvbdev.c:529 dvb_register_device() error: double unlock 'sem:&minor_rwsem' |
| |
| Reported-by: Hans Verkuil <hverkuil@xs4all.nl> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> |
| Stable-dep-of: 8c64f4cdf4e6 ("media: edia: dvbdev: fix a use-after-free") |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/dvb-core/dvbdev.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c |
| index b8335ede66264..1f80c4fa31c9b 100644 |
| --- a/drivers/media/dvb-core/dvbdev.c |
| +++ b/drivers/media/dvb-core/dvbdev.c |
| @@ -536,7 +536,6 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev, |
| dvb_media_device_free(dvbdev); |
| kfree(dvbdevfops); |
| kfree(dvbdev); |
| - up_write(&minor_rwsem); |
| mutex_unlock(&dvbdev_register_lock); |
| return ret; |
| } |
| -- |
| 2.43.0 |
| |
