| From 2f5509d61396124556cf7a2124a3a819cc3657b8 Mon Sep 17 00:00:00 2001 |
| From: Qian Cai <cai@lca.pw> |
| Date: Thu, 6 Jun 2019 09:58:13 -0400 |
| Subject: powerpc/cacheflush: fix variable set but not used |
| |
| [ Upstream commit 04db3ede40ae4fc23a5c4237254c4a53bbe4c1f2 ] |
| |
| The powerpc's flush_cache_vmap() is defined as a macro and never use |
| both of its arguments, so it will generate a compilation warning, |
| |
| lib/ioremap.c: In function 'ioremap_page_range': |
| lib/ioremap.c:203:16: warning: variable 'start' set but not used |
| [-Wunused-but-set-variable] |
| |
| Fix it by making it an inline function. |
| |
| Signed-off-by: Qian Cai <cai@lca.pw> |
| Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/powerpc/include/asm/cacheflush.h | 7 +++++-- |
| 1 file changed, 5 insertions(+), 2 deletions(-) |
| |
| diff --git a/arch/powerpc/include/asm/cacheflush.h b/arch/powerpc/include/asm/cacheflush.h |
| index d5a8d7bf0759..b189f7aee222 100644 |
| --- a/arch/powerpc/include/asm/cacheflush.h |
| +++ b/arch/powerpc/include/asm/cacheflush.h |
| @@ -32,9 +32,12 @@ |
| * not expect this type of fault. flush_cache_vmap is not exactly the right |
| * place to put this, but it seems to work well enough. |
| */ |
| -#define flush_cache_vmap(start, end) do { asm volatile("ptesync" ::: "memory"); } while (0) |
| +static inline void flush_cache_vmap(unsigned long start, unsigned long end) |
| +{ |
| + asm volatile("ptesync" ::: "memory"); |
| +} |
| #else |
| -#define flush_cache_vmap(start, end) do { } while (0) |
| +static inline void flush_cache_vmap(unsigned long start, unsigned long end) { } |
| #endif |
| |
| #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1 |
| -- |
| 2.20.1 |
| |