| From arnd@arndb.de Mon Jan 9 12:26:47 2017 |
| From: Arnd Bergmann <arnd@arndb.de> |
| Date: Mon, 9 Jan 2017 11:47:50 +0100 |
| Subject: stable-fixup: hotplug: fix unused function warning |
| To: stable@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Cc: Thomas Gleixner <tglx@linutronix.de>, Dan Streetman <ddstreet@ieee.org>, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, Michal Hocko <mhocko@suse.com>, Yu Zhao <yuzhao@google.com>, Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org |
| Message-ID: <20170109104811.1453295-1-arnd@arndb.de> |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| [resolves a messed up backport, so no matching upstream commit] |
| |
| The backport of upstream commit 777c6e0daebb ("hotplug: Make |
| register and unregister notifier API symmetric") to linux-4.4.y |
| introduced a harmless warning in 'allnoconfig' builds as spotted by |
| kernelci.org: |
| |
| kernel/cpu.c:226:13: warning: 'cpu_notify_nofail' defined but not used [-Wunused-function] |
| |
| So far, this is the only stable tree that is affected, as linux-4.6 and |
| higher contain commit 984581728eb4 ("cpu/hotplug: Split out cpu down functions") |
| that makes the function used in all configurations, while older longterm |
| releases so far don't seem to have a backport of 777c6e0daebb. |
| |
| The fix for the warning is trivial: move the unused function back |
| into the #ifdef section where it was before. |
| |
| Link: https://kernelci.org/build/id/586fcacb59b514049ef6c3aa/logs/ |
| Fixes: 1c0f4e0ebb79 ("hotplug: Make register and unregister notifier API symmetric") in v4.4.y |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| kernel/cpu.c | 9 +++++---- |
| 1 file changed, 5 insertions(+), 4 deletions(-) |
| |
| --- a/kernel/cpu.c |
| +++ b/kernel/cpu.c |
| @@ -223,10 +223,6 @@ static int cpu_notify(unsigned long val, |
| return __cpu_notify(val, v, -1, NULL); |
| } |
| |
| -static void cpu_notify_nofail(unsigned long val, void *v) |
| -{ |
| - BUG_ON(cpu_notify(val, v)); |
| -} |
| EXPORT_SYMBOL(register_cpu_notifier); |
| EXPORT_SYMBOL(__register_cpu_notifier); |
| |
| @@ -245,6 +241,11 @@ void __unregister_cpu_notifier(struct no |
| EXPORT_SYMBOL(__unregister_cpu_notifier); |
| |
| #ifdef CONFIG_HOTPLUG_CPU |
| +static void cpu_notify_nofail(unsigned long val, void *v) |
| +{ |
| + BUG_ON(cpu_notify(val, v)); |
| +} |
| + |
| /** |
| * clear_tasks_mm_cpumask - Safely clear tasks' mm_cpumask for a CPU |
| * @cpu: a CPU id |