| From foo@baz Mon Sep 24 09:32:39 CEST 2018 |
| From: Wei Yongjun <weiyongjun1@huawei.com> |
| Date: Wed, 11 Jul 2018 13:19:38 +0000 |
| Subject: gpio: pxa: Fix potential NULL dereference |
| |
| From: Wei Yongjun <weiyongjun1@huawei.com> |
| |
| [ Upstream commit 9506755633d0b32ef76f67c345000178e9b0dfc4 ] |
| |
| platform_get_resource() may fail and return NULL, so we should |
| better check it's return value to avoid a NULL pointer dereference |
| a bit later in the code. |
| |
| This is detected by Coccinelle semantic patch. |
| |
| @@ |
| expression pdev, res, n, t, e, e1, e2; |
| @@ |
| |
| res = platform_get_resource(pdev, t, n); |
| + if (!res) |
| + return -EINVAL; |
| ... when != res == NULL |
| e = devm_ioremap(e1, res->start, e2); |
| |
| Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> |
| Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/gpio/gpio-pxa.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/drivers/gpio/gpio-pxa.c |
| +++ b/drivers/gpio/gpio-pxa.c |
| @@ -660,6 +660,8 @@ static int pxa_gpio_probe(struct platfor |
| pchip->irq0 = irq0; |
| pchip->irq1 = irq1; |
| res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| + if (!res) |
| + return -EINVAL; |
| gpio_reg_base = devm_ioremap(&pdev->dev, res->start, |
| resource_size(res)); |
| if (!gpio_reg_base) |
