| From f647de23f7d58d1328b9471e51863a0d57fe561b Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 18 Jan 2023 14:20:36 +0800 |
| Subject: pinctrl: mediatek: Initialize variable *buf to zero |
| |
| From: Guodong Liu <Guodong.Liu@mediatek.com> |
| |
| [ Upstream commit 2e34f82ba214134ecf590fbe0cdbd87401645a8a ] |
| |
| Coverity spotted that *buf is not initialized to zero in |
| mtk_pctrl_dbg_show. Using uninitialized variable *buf as argument to %s |
| when calling seq_printf. Fix this coverity by initializing *buf as zero. |
| |
| Fixes: 184d8e13f9b1 ("pinctrl: mediatek: Add support for pin configuration dump via debugfs.") |
| Signed-off-by: Guodong Liu <Guodong.Liu@mediatek.com> |
| Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> |
| Link: https://lore.kernel.org/r/20230118062036.26258-3-Guodong.Liu@mediatek.com |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pinctrl/mediatek/pinctrl-paris.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c |
| index 2a9d2801388d7..e486d66e220b0 100644 |
| --- a/drivers/pinctrl/mediatek/pinctrl-paris.c |
| +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c |
| @@ -637,7 +637,7 @@ static void mtk_pctrl_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s, |
| unsigned int gpio) |
| { |
| struct mtk_pinctrl *hw = pinctrl_dev_get_drvdata(pctldev); |
| - char buf[PIN_DBG_BUF_SZ]; |
| + char buf[PIN_DBG_BUF_SZ] = { 0 }; |
| |
| (void)mtk_pctrl_show_one_pin(hw, gpio, buf, PIN_DBG_BUF_SZ); |
| |
| -- |
| 2.39.2 |
| |