| From 3220d471aa008f91ebfcee25fd90f928161295a3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 5 May 2023 14:35:57 +0800 |
| Subject: spi: lpspi: disable lpspi module irq in DMA mode |
| |
| From: Clark Wang <xiaoning.wang@nxp.com> |
| |
| [ Upstream commit 9728fb3ce11729aa8c276825ddf504edeb00611d ] |
| |
| When all bits of IER are set to 0, we still can observe the lpspi irq events |
| when using DMA mode to transfer data. |
| |
| So disable irq to avoid the too much irq events. |
| |
| Signed-off-by: Clark Wang <xiaoning.wang@nxp.com> |
| Link: https://lore.kernel.org/r/20230505063557.3962220-1-xiaoning.wang@nxp.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/spi/spi-fsl-lpspi.c | 7 ++++++- |
| 1 file changed, 6 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c |
| index 5d98611dd999d..c5ff6e8c45be0 100644 |
| --- a/drivers/spi/spi-fsl-lpspi.c |
| +++ b/drivers/spi/spi-fsl-lpspi.c |
| @@ -906,9 +906,14 @@ static int fsl_lpspi_probe(struct platform_device *pdev) |
| ret = fsl_lpspi_dma_init(&pdev->dev, fsl_lpspi, controller); |
| if (ret == -EPROBE_DEFER) |
| goto out_pm_get; |
| - |
| if (ret < 0) |
| dev_err(&pdev->dev, "dma setup error %d, use pio\n", ret); |
| + else |
| + /* |
| + * disable LPSPI module IRQ when enable DMA mode successfully, |
| + * to prevent the unexpected LPSPI module IRQ events. |
| + */ |
| + disable_irq(irq); |
| |
| ret = devm_spi_register_controller(&pdev->dev, controller); |
| if (ret < 0) { |
| -- |
| 2.39.2 |
| |