| From abf00d47599a483e5a7611ae21fef9bb7a192bbe Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 12 Nov 2025 19:27:24 +0100 |
| Subject: s390/ctcm: Fix double-kfree |
| |
| From: Aleksei Nikiforov <aleksei.nikiforov@linux.ibm.com> |
| |
| [ Upstream commit da02a1824884d6c84c5e5b5ac373b0c9e3288ec2 ] |
| |
| The function 'mpc_rcvd_sweep_req(mpcginfo)' is called conditionally |
| from function 'ctcmpc_unpack_skb'. It frees passed mpcginfo. |
| After that a call to function 'kfree' in function 'ctcmpc_unpack_skb' |
| frees it again. |
| |
| Remove 'kfree' call in function 'mpc_rcvd_sweep_req(mpcginfo)'. |
| |
| Bug detected by the clang static analyzer. |
| |
| Fixes: 0c0b20587b9f25a2 ("s390/ctcm: fix potential memory leak") |
| Reviewed-by: Aswin Karuvally <aswin@linux.ibm.com> |
| Signed-off-by: Aleksei Nikiforov <aleksei.nikiforov@linux.ibm.com> |
| Signed-off-by: Aswin Karuvally <aswin@linux.ibm.com> |
| Reviewed-by: Simon Horman <horms@kernel.org> |
| Link: https://patch.msgid.link/20251112182724.1109474-1-aswin@linux.ibm.com |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/s390/net/ctcm_mpc.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/drivers/s390/net/ctcm_mpc.c b/drivers/s390/net/ctcm_mpc.c |
| index 20a6097e1b204..4e6f340d09261 100644 |
| --- a/drivers/s390/net/ctcm_mpc.c |
| +++ b/drivers/s390/net/ctcm_mpc.c |
| @@ -712,7 +712,6 @@ static void mpc_rcvd_sweep_req(struct mpcg_info *mpcginfo) |
| |
| grp->sweep_req_pend_num--; |
| ctcmpc_send_sweep_resp(ch); |
| - kfree(mpcginfo); |
| return; |
| } |
| |
| -- |
| 2.51.0 |
| |
