| From 918aa1ef104d286d16b9e7ef139a463ac7a296f0 Mon Sep 17 00:00:00 2001 |
| From: Benjamin Tissoires <benjamin.tissoires@redhat.com> |
| Date: Thu, 2 Dec 2021 10:53:32 +0100 |
| Subject: HID: bigbenff: prevent null pointer dereference |
| |
| From: Benjamin Tissoires <benjamin.tissoires@redhat.com> |
| |
| commit 918aa1ef104d286d16b9e7ef139a463ac7a296f0 upstream. |
| |
| When emulating the device through uhid, there is a chance we don't have |
| output reports and so report_field is null. |
| |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> |
| Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Link: https://lore.kernel.org/r/20211202095334.14399-3-benjamin.tissoires@redhat.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/hid/hid-bigbenff.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/hid/hid-bigbenff.c |
| +++ b/drivers/hid/hid-bigbenff.c |
| @@ -191,7 +191,7 @@ static void bigben_worker(struct work_st |
| struct bigben_device, worker); |
| struct hid_field *report_field = bigben->report->field[0]; |
| |
| - if (bigben->removed) |
| + if (bigben->removed || !report_field) |
| return; |
| |
| if (bigben->work_led) { |
