| From 87b76a6e09176d96f96f049351bf2a1d55fad646 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 29 May 2022 23:34:55 +0800 |
| Subject: scsi: pmcraid: Fix missing resource cleanup in error case |
| |
| From: Chengguang Xu <cgxu519@mykernel.net> |
| |
| [ Upstream commit ec1e8adcbdf661c57c395bca342945f4f815add7 ] |
| |
| Fix missing resource cleanup (when '(--i) == 0') for error case in |
| pmcraid_register_interrupt_handler(). |
| |
| Link: https://lore.kernel.org/r/20220529153456.4183738-6-cgxu519@mykernel.net |
| Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Chengguang Xu <cgxu519@mykernel.net> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/scsi/pmcraid.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c |
| index fd674ed1febe..6d94837c9049 100644 |
| --- a/drivers/scsi/pmcraid.c |
| +++ b/drivers/scsi/pmcraid.c |
| @@ -4031,7 +4031,7 @@ pmcraid_register_interrupt_handler(struct pmcraid_instance *pinstance) |
| return 0; |
| |
| out_unwind: |
| - while (--i > 0) |
| + while (--i >= 0) |
| free_irq(pci_irq_vector(pdev, i), &pinstance->hrrq_vector[i]); |
| pci_free_irq_vectors(pdev); |
| return rc; |
| -- |
| 2.35.1 |
| |
