| From foo@baz Fri 26 Jul 2019 10:49:18 AM CEST |
| From: Yang Wei <albin_yang@163.com> |
| Date: Mon, 8 Jul 2019 22:57:39 +0800 |
| Subject: nfc: fix potential illegal memory access |
| |
| From: Yang Wei <albin_yang@163.com> |
| |
| [ Upstream commit dd006fc434e107ef90f7de0db9907cbc1c521645 ] |
| |
| The frags_q is not properly initialized, it may result in illegal memory |
| access when conn_info is NULL. |
| The "goto free_exit" should be replaced by "goto exit". |
| |
| Signed-off-by: Yang Wei <albin_yang@163.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/nfc/nci/data.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/nfc/nci/data.c |
| +++ b/net/nfc/nci/data.c |
| @@ -107,7 +107,7 @@ static int nci_queue_tx_data_frags(struc |
| conn_info = nci_get_conn_info_by_conn_id(ndev, conn_id); |
| if (!conn_info) { |
| rc = -EPROTO; |
| - goto free_exit; |
| + goto exit; |
| } |
| |
| __skb_queue_head_init(&frags_q); |