| From def65e8a4cdfe892f3784069fee0324b4e06e876 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 26 Jul 2022 14:36:05 -0700 |
| Subject: netdevsim: Avoid allocation warnings triggered from user space |
| |
| From: Jakub Kicinski <kuba@kernel.org> |
| |
| [ Upstream commit d0b80a9edb1a029ff913e81b47540e57ad034329 ] |
| |
| We need to suppress warnings from sily map sizes. Also switch |
| from GFP_USER to GFP_KERNEL_ACCOUNT, I'm pretty sure I misunderstood |
| the flags when writing this code. |
| |
| Fixes: 395cacb5f1a0 ("netdevsim: bpf: support fake map offload") |
| Reported-by: syzbot+ad24705d3fd6463b18c6@syzkaller.appspotmail.com |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Andrii Nakryiko <andrii@kernel.org> |
| Link: https://lore.kernel.org/bpf/20220726213605.154204-1-kuba@kernel.org |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/netdevsim/bpf.c | 8 +++++--- |
| 1 file changed, 5 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/net/netdevsim/bpf.c b/drivers/net/netdevsim/bpf.c |
| index e0a4acc6144b..8e47755cc159 100644 |
| --- a/drivers/net/netdevsim/bpf.c |
| +++ b/drivers/net/netdevsim/bpf.c |
| @@ -347,10 +347,12 @@ nsim_map_alloc_elem(struct bpf_offloaded_map *offmap, unsigned int idx) |
| { |
| struct nsim_bpf_bound_map *nmap = offmap->dev_priv; |
| |
| - nmap->entry[idx].key = kmalloc(offmap->map.key_size, GFP_USER); |
| + nmap->entry[idx].key = kmalloc(offmap->map.key_size, |
| + GFP_KERNEL_ACCOUNT | __GFP_NOWARN); |
| if (!nmap->entry[idx].key) |
| return -ENOMEM; |
| - nmap->entry[idx].value = kmalloc(offmap->map.value_size, GFP_USER); |
| + nmap->entry[idx].value = kmalloc(offmap->map.value_size, |
| + GFP_KERNEL_ACCOUNT | __GFP_NOWARN); |
| if (!nmap->entry[idx].value) { |
| kfree(nmap->entry[idx].key); |
| nmap->entry[idx].key = NULL; |
| @@ -492,7 +494,7 @@ nsim_bpf_map_alloc(struct netdevsim *ns, struct bpf_offloaded_map *offmap) |
| if (offmap->map.map_flags) |
| return -EINVAL; |
| |
| - nmap = kzalloc(sizeof(*nmap), GFP_USER); |
| + nmap = kzalloc(sizeof(*nmap), GFP_KERNEL_ACCOUNT); |
| if (!nmap) |
| return -ENOMEM; |
| |
| -- |
| 2.35.1 |
| |