| From 401b64c6ee93ae3d8999b5c20a2621e2814feec9 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 24 Jan 2020 09:10:47 +0300 |
| Subject: help_next should increase position index |
| |
| From: Vasily Averin <vvs@virtuozzo.com> |
| |
| [ Upstream commit 9f198a2ac543eaaf47be275531ad5cbd50db3edf ] |
| |
| if seq_file .next fuction does not change position index, |
| read after some lseek can generate unexpected output. |
| |
| https://bugzilla.kernel.org/show_bug.cgi?id=206283 |
| Signed-off-by: Vasily Averin <vvs@virtuozzo.com> |
| Signed-off-by: Mike Marshall <hubcap@omnibond.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/orangefs/orangefs-debugfs.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c |
| index 25543a966c486..29eaa45443727 100644 |
| --- a/fs/orangefs/orangefs-debugfs.c |
| +++ b/fs/orangefs/orangefs-debugfs.c |
| @@ -273,6 +273,7 @@ static void *help_start(struct seq_file *m, loff_t *pos) |
| |
| static void *help_next(struct seq_file *m, void *v, loff_t *pos) |
| { |
| + (*pos)++; |
| gossip_debug(GOSSIP_DEBUGFS_DEBUG, "help_next: start\n"); |
| |
| return NULL; |
| -- |
| 2.20.1 |
| |
