| From 356ffeccef0fa499662e47a8349a560dee6d8910 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 18 Dec 2024 09:58:31 +0100 |
| Subject: drm/mediatek: stop selecting foreign drivers |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| [ Upstream commit 924d66011f2401a4145e2e814842c5c4572e439f ] |
| |
| The PHY portion of the mediatek hdmi driver was originally part of |
| the driver it self and later split out into drivers/phy, which a |
| 'select' to keep the prior behavior. |
| |
| However, this leads to build failures when the PHY driver cannot |
| be built: |
| |
| WARNING: unmet direct dependencies detected for PHY_MTK_HDMI |
| Depends on [n]: (ARCH_MEDIATEK || COMPILE_TEST [=y]) && COMMON_CLK [=y] && OF [=y] && REGULATOR [=n] |
| Selected by [m]: |
| - DRM_MEDIATEK_HDMI [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_MEDIATEK [=m] |
| ERROR: modpost: "devm_regulator_register" [drivers/phy/mediatek/phy-mtk-hdmi-drv.ko] undefined! |
| ERROR: modpost: "rdev_get_drvdata" [drivers/phy/mediatek/phy-mtk-hdmi-drv.ko] undefined! |
| |
| The best option here is to just not select the phy driver and leave that |
| up to the defconfig. Do the same for the other PHY and memory drivers |
| selected here as well for consistency. |
| |
| Fixes: a481bf2f0ca4 ("drm/mediatek: Separate mtk_hdmi_phy to an independent module") |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> |
| Reviewed-by: CK Hu <ck.hu@mediatek.com> |
| Link: https://patchwork.kernel.org/project/dri-devel/patch/20241218085837.2670434-1-arnd@kernel.org/ |
| Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/mediatek/Kconfig | 5 ----- |
| 1 file changed, 5 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig |
| index d1eededee943..d663869bfce1 100644 |
| --- a/drivers/gpu/drm/mediatek/Kconfig |
| +++ b/drivers/gpu/drm/mediatek/Kconfig |
| @@ -11,9 +11,6 @@ config DRM_MEDIATEK |
| select DRM_KMS_HELPER |
| select DRM_MIPI_DSI |
| select DRM_PANEL |
| - select MEMORY |
| - select MTK_SMI |
| - select PHY_MTK_MIPI_DSI |
| select VIDEOMODE_HELPERS |
| help |
| Choose this option if you have a Mediatek SoCs. |
| @@ -24,7 +21,6 @@ config DRM_MEDIATEK |
| config DRM_MEDIATEK_DP |
| tristate "DRM DPTX Support for MediaTek SoCs" |
| depends on DRM_MEDIATEK |
| - select PHY_MTK_DP |
| select DRM_DISPLAY_HELPER |
| select DRM_DISPLAY_DP_HELPER |
| select DRM_DP_AUX_BUS |
| @@ -35,6 +31,5 @@ config DRM_MEDIATEK_HDMI |
| tristate "DRM HDMI Support for Mediatek SoCs" |
| depends on DRM_MEDIATEK |
| select SND_SOC_HDMI_CODEC if SND_SOC |
| - select PHY_MTK_HDMI |
| help |
| DRM/KMS HDMI driver for Mediatek SoCs |
| -- |
| 2.39.5 |
| |
