| From 3b5a044d9f22339a0d62ec18c15a0401ca7a1128 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 13 Dec 2022 19:56:17 +0800 |
| Subject: ASoC: SOF: mediatek: initialize panic_info to zero |
| |
| From: YC Hung <yc.hung@mediatek.com> |
| |
| [ Upstream commit 7bd220f2ba9014b78f0304178103393554b8c4fe ] |
| |
| Coverity spotted that panic_info is not initialized to zero in |
| mtk_adsp_dump. Using uninitialized value panic_info.linenum when |
| calling snd_sof_get_status. Fix this coverity by initializing |
| panic_info struct as zero. |
| |
| Signed-off-by: YC Hung <yc.hung@mediatek.com> |
| Reviewed-by: Curtis Malainey <cujomalainey@chromium.org> |
| Link: https://lore.kernel.org/r/20221213115617.25086-1-yc.hung@mediatek.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/soc/sof/mediatek/mtk-adsp-common.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/sound/soc/sof/mediatek/mtk-adsp-common.c b/sound/soc/sof/mediatek/mtk-adsp-common.c |
| index 1e0769c668a7..de8dbe27cd0d 100644 |
| --- a/sound/soc/sof/mediatek/mtk-adsp-common.c |
| +++ b/sound/soc/sof/mediatek/mtk-adsp-common.c |
| @@ -60,7 +60,7 @@ void mtk_adsp_dump(struct snd_sof_dev *sdev, u32 flags) |
| { |
| char *level = (flags & SOF_DBG_DUMP_OPTIONAL) ? KERN_DEBUG : KERN_ERR; |
| struct sof_ipc_dsp_oops_xtensa xoops; |
| - struct sof_ipc_panic_info panic_info; |
| + struct sof_ipc_panic_info panic_info = {}; |
| u32 stack[MTK_ADSP_STACK_DUMP_SIZE]; |
| u32 status; |
| |
| -- |
| 2.35.1 |
| |