| From 76cb7dc726e88b229d539ba1fafcd7edbe6a83df Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 5 Dec 2022 11:08:40 -0500 |
| Subject: drm/amd/display: Uninitialized variables causing 4k60 UCLK to stay at |
| DPM1 and not DPM0 |
| |
| From: Samson Tam <samson.tam@amd.com> |
| |
| [ Upstream commit f3c23bea598ab7e8e4b8c5ca66598921310f718e ] |
| |
| [Why] |
| SwathSizePerSurfaceY[] and SwathSizePerSurfaceC[] values are uninitialized |
| because we are using += instead of = operator. |
| |
| [How] |
| Assign values in loop with = operator. |
| |
| Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com> |
| Signed-off-by: Samson Tam <samson.tam@amd.com> |
| Reviewed-by: Aric Cyr <aric.cyr@amd.com> |
| Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Cc: stable@vger.kernel.org # 6.0.x, 6.1.x |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c |
| index 5af601cff1a0..b53feeaf5cf1 100644 |
| --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c |
| +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c |
| @@ -6257,12 +6257,12 @@ bool dml32_CalculateDETSwathFillLatencyHiding(unsigned int NumberOfActiveSurface |
| double SwathSizePerSurfaceC[DC__NUM_DPP__MAX]; |
| bool NotEnoughDETSwathFillLatencyHiding = false; |
| |
| - /* calculate sum of single swath size for all pipes in bytes*/ |
| + /* calculate sum of single swath size for all pipes in bytes */ |
| for (k = 0; k < NumberOfActiveSurfaces; k++) { |
| - SwathSizePerSurfaceY[k] += SwathHeightY[k] * SwathWidthY[k] * BytePerPixelInDETY[k] * NumOfDPP[k]; |
| + SwathSizePerSurfaceY[k] = SwathHeightY[k] * SwathWidthY[k] * BytePerPixelInDETY[k] * NumOfDPP[k]; |
| |
| if (SwathHeightC[k] != 0) |
| - SwathSizePerSurfaceC[k] += SwathHeightC[k] * SwathWidthC[k] * BytePerPixelInDETC[k] * NumOfDPP[k]; |
| + SwathSizePerSurfaceC[k] = SwathHeightC[k] * SwathWidthC[k] * BytePerPixelInDETC[k] * NumOfDPP[k]; |
| else |
| SwathSizePerSurfaceC[k] = 0; |
| |
| -- |
| 2.35.1 |
| |