| From c21bdb3d8a850afdfa4afe77eea39ae9533629b0 Mon Sep 17 00:00:00 2001 |
| From: Miguel Ojeda <ojeda@kernel.org> |
| Date: Tue, 21 Jan 2025 21:09:34 +0100 |
| Subject: rust: init: use explicit ABI to clean warning in future compilers |
| |
| From: Miguel Ojeda <ojeda@kernel.org> |
| |
| commit c21bdb3d8a850afdfa4afe77eea39ae9533629b0 upstream. |
| |
| Starting with Rust 1.86.0 (currently in nightly, to be released on |
| 2025-04-03), the `missing_abi` lint is warn-by-default [1]: |
| |
| error: extern declarations without an explicit ABI are deprecated |
| --> rust/doctests_kernel_generated.rs:3158:1 |
| | |
| 3158 | extern { |
| | ^^^^^^ help: explicitly specify the C ABI: `extern "C"` |
| | |
| = note: `-D missing-abi` implied by `-D warnings` |
| = help: to override `-D warnings` add `#[allow(missing_abi)]` |
| |
| Thus clean it up. |
| |
| Cc: <stable@vger.kernel.org> # Needed in 6.12.y and 6.13.y only (Rust is pinned in older LTSs). |
| Fixes: 7f8977a7fe6d ("rust: init: add `{pin_}chain` functions to `{Pin}Init<T, E>`") |
| Link: https://github.com/rust-lang/rust/pull/132397 [1] |
| Reviewed-by: Gary Guo <gary@garyguo.net> |
| Reviewed-by: Alice Ryhl <aliceryhl@google.com> |
| Reviewed-by: Fiona Behrens <me@kloenk.dev> |
| Link: https://lore.kernel.org/r/20250121200934.222075-1-ojeda@kernel.org |
| [ Added 6.13.y to Cc: stable tag. - Miguel ] |
| Signed-off-by: Miguel Ojeda <ojeda@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| rust/kernel/init.rs | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/rust/kernel/init.rs |
| +++ b/rust/kernel/init.rs |
| @@ -854,7 +854,7 @@ pub unsafe trait PinInit<T: ?Sized, E = |
| /// use kernel::{types::Opaque, init::pin_init_from_closure}; |
| /// #[repr(C)] |
| /// struct RawFoo([u8; 16]); |
| - /// extern { |
| + /// extern "C" { |
| /// fn init_foo(_: *mut RawFoo); |
| /// } |
| /// |