| From 2dfcf9c51ad5f6202d1d9684d38d88f3139c9afb Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 12 Feb 2025 18:18:51 +0200 |
| Subject: drm: Fix DSC BPP increment decoding |
| |
| From: Imre Deak <imre.deak@intel.com> |
| |
| [ Upstream commit e00a2e5d485faf53c7a24b9d1b575a642227947f ] |
| |
| Starting with DPCD version 2.0 bits 6:3 of the DP_DSC_BITS_PER_PIXEL_INC |
| DPCD register contains the NativeYCbCr422_MAX_bpp_DELTA field, which can |
| be non-zero as opposed to earlier DPCD versions, hence decoding the |
| bit_per_pixel increment value at bits 2:0 in the same register requires |
| applying a mask, do so. |
| |
| Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> |
| Fixes: 0c2287c96521 ("drm/display/dp: Add helper function to get DSC bpp precision") |
| Reviewed-by: Jani Nikula <jani.nikula@intel.com> |
| Signed-off-by: Imre Deak <imre.deak@intel.com> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20250212161851.4007005-1-imre.deak@intel.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/display/drm_dp_helper.c | 2 +- |
| include/drm/display/drm_dp.h | 1 + |
| 2 files changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c |
| index 6ee51003de3ce..9fa13da513d24 100644 |
| --- a/drivers/gpu/drm/display/drm_dp_helper.c |
| +++ b/drivers/gpu/drm/display/drm_dp_helper.c |
| @@ -2421,7 +2421,7 @@ u8 drm_dp_dsc_sink_bpp_incr(const u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE]) |
| { |
| u8 bpp_increment_dpcd = dsc_dpcd[DP_DSC_BITS_PER_PIXEL_INC - DP_DSC_SUPPORT]; |
| |
| - switch (bpp_increment_dpcd) { |
| + switch (bpp_increment_dpcd & DP_DSC_BITS_PER_PIXEL_MASK) { |
| case DP_DSC_BITS_PER_PIXEL_1_16: |
| return 16; |
| case DP_DSC_BITS_PER_PIXEL_1_8: |
| diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h |
| index a6f8b098c56f1..3bd9f482f0c3e 100644 |
| --- a/include/drm/display/drm_dp.h |
| +++ b/include/drm/display/drm_dp.h |
| @@ -359,6 +359,7 @@ |
| # define DP_DSC_BITS_PER_PIXEL_1_4 0x2 |
| # define DP_DSC_BITS_PER_PIXEL_1_2 0x3 |
| # define DP_DSC_BITS_PER_PIXEL_1_1 0x4 |
| +# define DP_DSC_BITS_PER_PIXEL_MASK 0x7 |
| |
| #define DP_PSR_SUPPORT 0x070 /* XXX 1.2? */ |
| # define DP_PSR_IS_SUPPORTED 1 |
| -- |
| 2.39.5 |
| |