| From a77249a1b43ac5044ea4ad67d6386c587319bbc0 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 4 Sep 2023 22:04:06 +0200 |
| Subject: regmap: debugfs: Fix a erroneous check after snprintf() |
| |
| From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| |
| [ Upstream commit d3601857e14de6369f00ae19564f1d817d175d19 ] |
| |
| This error handling looks really strange. |
| Check if the string has been truncated instead. |
| |
| Fixes: f0c2319f9f19 ("regmap: Expose the driver name in debugfs") |
| Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| Link: https://lore.kernel.org/r/8595de2462c490561f70020a6d11f4d6b652b468.1693857825.git.christophe.jaillet@wanadoo.fr |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/base/regmap/regmap-debugfs.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c |
| index f36027591e1a8..bdd80b73c3e6c 100644 |
| --- a/drivers/base/regmap/regmap-debugfs.c |
| +++ b/drivers/base/regmap/regmap-debugfs.c |
| @@ -48,7 +48,7 @@ static ssize_t regmap_name_read_file(struct file *file, |
| name = map->dev->driver->name; |
| |
| ret = snprintf(buf, PAGE_SIZE, "%s\n", name); |
| - if (ret < 0) { |
| + if (ret >= PAGE_SIZE) { |
| kfree(buf); |
| return ret; |
| } |
| -- |
| 2.42.0 |
| |
