| From d296ffb31209cb7023dbc56e8b024bd5dbbf1fb3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 27 Jun 2024 20:05:14 -0600 |
| Subject: drm/amd/display: Check stream before comparing them |
| |
| From: Alex Hung <alex.hung@amd.com> |
| |
| [ Upstream commit 35ff747c86767937ee1e0ca987545b7eed7a0810 ] |
| |
| [WHAT & HOW] |
| amdgpu_dm can pass a null stream to dc_is_stream_unchanged. It is |
| necessary to check for null before dereferencing them. |
| |
| This fixes 1 FORWARD_NULL issue reported by Coverity. |
| |
| Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com> |
| Signed-off-by: Jerry Zuo <jerry.zuo@amd.com> |
| Signed-off-by: Alex Hung <alex.hung@amd.com> |
| Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c |
| index 4b34bc9d4e4be..99fcd39bb15e0 100644 |
| --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c |
| +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c |
| @@ -2154,6 +2154,8 @@ static bool are_stream_backends_same( |
| bool dc_is_stream_unchanged( |
| struct dc_stream_state *old_stream, struct dc_stream_state *stream) |
| { |
| + if (!old_stream || !stream) |
| + return false; |
| |
| if (!are_stream_backends_same(old_stream, stream)) |
| return false; |
| -- |
| 2.43.0 |
| |
