| From e45f6588e7e731be49298ea5a5e8fc5d150f507f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 3 Mar 2025 23:37:44 +0100 |
| Subject: rtc: ds1307: stop disabling alarms on probe |
| |
| From: Alexandre Belloni <alexandre.belloni@bootlin.com> |
| |
| [ Upstream commit dcec12617ee61beed928e889607bf37e145bf86b ] |
| |
| It is a bad practice to disable alarms on probe or remove as this will |
| prevent alarms across reboots. |
| |
| Link: https://lore.kernel.org/r/20250303223744.1135672-1-alexandre.belloni@bootlin.com |
| Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/rtc/rtc-ds1307.c | 4 +--- |
| 1 file changed, 1 insertion(+), 3 deletions(-) |
| |
| diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c |
| index 506b7d1c23970..0c78451960926 100644 |
| --- a/drivers/rtc/rtc-ds1307.c |
| +++ b/drivers/rtc/rtc-ds1307.c |
| @@ -1802,10 +1802,8 @@ static int ds1307_probe(struct i2c_client *client) |
| * For some variants, be sure alarms can trigger when we're |
| * running on Vbackup (BBSQI/BBSQW) |
| */ |
| - if (want_irq || ds1307_can_wakeup_device) { |
| + if (want_irq || ds1307_can_wakeup_device) |
| regs[0] |= DS1337_BIT_INTCN | chip->bbsqi_bit; |
| - regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE); |
| - } |
| |
| regmap_write(ds1307->regmap, DS1337_REG_CONTROL, |
| regs[0]); |
| -- |
| 2.39.5 |
| |
