| From 2ea819fa166911fff96755b1114775aa459077d1 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 20 Feb 2024 15:35:24 +0000 |
| Subject: backlight: da9052: Fully initialize backlight_properties during probe |
| |
| From: Daniel Thompson <daniel.thompson@linaro.org> |
| |
| [ Upstream commit 0285e9efaee8276305db5c52a59baf84e9731556 ] |
| |
| props is stack allocated and the fields that are not explcitly set |
| by the probe function need to be zeroed or we'll get undefined behaviour |
| (especially so power/blank states)! |
| |
| Fixes: 6ede3d832aaa ("backlight: add driver for DA9052/53 PMIC v1") |
| Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> |
| Link: https://lore.kernel.org/r/20240220153532.76613-2-daniel.thompson@linaro.org |
| Signed-off-by: Lee Jones <lee@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/video/backlight/da9052_bl.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/video/backlight/da9052_bl.c b/drivers/video/backlight/da9052_bl.c |
| index 1cdc8543310b4..b8ff7046510eb 100644 |
| --- a/drivers/video/backlight/da9052_bl.c |
| +++ b/drivers/video/backlight/da9052_bl.c |
| @@ -117,6 +117,7 @@ static int da9052_backlight_probe(struct platform_device *pdev) |
| wleds->led_reg = platform_get_device_id(pdev)->driver_data; |
| wleds->state = DA9052_WLEDS_OFF; |
| |
| + memset(&props, 0, sizeof(struct backlight_properties)); |
| props.type = BACKLIGHT_RAW; |
| props.max_brightness = DA9052_MAX_BRIGHTNESS; |
| |
| -- |
| 2.43.0 |
| |
