| From d505456082125da8023d776a7db06795b41ef770 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 17 Apr 2024 21:10:40 +0300 |
| Subject: ext4: fix potential unnitialized variable |
| |
| From: Dan Carpenter <dan.carpenter@linaro.org> |
| |
| [ Upstream commit 3f4830abd236d0428e50451e1ecb62e14c365e9b ] |
| |
| Smatch complains "err" can be uninitialized in the caller. |
| |
| fs/ext4/indirect.c:349 ext4_alloc_branch() |
| error: uninitialized symbol 'err'. |
| |
| Set the error to zero on the success path. |
| |
| Fixes: 8016e29f4362 ("ext4: fast commit recovery path") |
| Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> |
| Link: https://lore.kernel.org/r/363a4673-0fb8-4adf-b4fb-90a499077276@moroto.mountain |
| Signed-off-by: Theodore Ts'o <tytso@mit.edu> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/ext4/mballoc.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c |
| index 12b3f196010b8..714f83632e3f9 100644 |
| --- a/fs/ext4/mballoc.c |
| +++ b/fs/ext4/mballoc.c |
| @@ -6113,6 +6113,7 @@ ext4_mb_new_blocks_simple(struct ext4_allocation_request *ar, int *errp) |
| ext4_mb_mark_bb(sb, block, 1, true); |
| ar->len = 1; |
| |
| + *errp = 0; |
| return block; |
| } |
| |
| -- |
| 2.43.0 |
| |
