| From ea8fed05ca00db885b26e6e96849b68f8a1328e4 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 26 Mar 2024 23:38:00 +0100 |
| Subject: fbdev: shmobile: fix snprintf truncation |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| [ Upstream commit 26c8cfb9d1e4b252336d23dd5127a8cbed414a32 ] |
| |
| The name of the overlay does not fit into the fixed-length field: |
| |
| drivers/video/fbdev/sh_mobile_lcdcfb.c:1577:2: error: 'snprintf' will always be truncated; specified size is 16, but format string expands to at least 25 |
| |
| Make it short enough by changing the string. |
| |
| Fixes: c5deac3c9b22 ("fbdev: sh_mobile_lcdc: Implement overlays support") |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> |
| Signed-off-by: Helge Deller <deller@gmx.de> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c |
| index eb2297b37504c..d35d2cf999988 100644 |
| --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c |
| +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c |
| @@ -1575,7 +1575,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl) |
| */ |
| info->fix = sh_mobile_lcdc_overlay_fix; |
| snprintf(info->fix.id, sizeof(info->fix.id), |
| - "SH Mobile LCDC Overlay %u", ovl->index); |
| + "SHMobile ovl %u", ovl->index); |
| info->fix.smem_start = ovl->dma_handle; |
| info->fix.smem_len = ovl->fb_size; |
| info->fix.line_length = ovl->pitch; |
| -- |
| 2.43.0 |
| |
