| From 86770b58aea143305e6f3dba452254060f4c31d5 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 19 Apr 2024 10:25:01 -0300 |
| Subject: kunit: unregister the device on error |
| |
| From: Wander Lairson Costa <wander@redhat.com> |
| |
| [ Upstream commit fabd480b721eb30aa4e2c89507b53933069f9f6e ] |
| |
| kunit_init_device() should unregister the device on bus register error, |
| but mistakenly it tries to unregister the bus. |
| |
| Unregister the device instead of the bus. |
| |
| Signed-off-by: Wander Lairson Costa <wander@redhat.com> |
| Fixes: d03c720e03bd ("kunit: Add APIs for managing devices") |
| Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Shuah Khan <skhan@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| lib/kunit/device.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/lib/kunit/device.c b/lib/kunit/device.c |
| index abc603730b8ea..25c81ed465fb7 100644 |
| --- a/lib/kunit/device.c |
| +++ b/lib/kunit/device.c |
| @@ -51,7 +51,7 @@ int kunit_bus_init(void) |
| |
| error = bus_register(&kunit_bus_type); |
| if (error) |
| - bus_unregister(&kunit_bus_type); |
| + root_device_unregister(kunit_bus_device); |
| return error; |
| } |
| |
| -- |
| 2.43.0 |
| |
