| From fc4a2ca6f254fcb8dfe43057500c393b582e60ff Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 27 May 2024 17:18:50 +0200 |
| Subject: ALSA: seq: Don't clear bank selection at event -> UMP MIDI2 |
| conversion |
| |
| From: Takashi Iwai <tiwai@suse.de> |
| |
| [ Upstream commit a200df7deb3186cd7b55abb77ab96dfefb8a4f09 ] |
| |
| The current code to convert from a legacy sequencer event to UMP MIDI2 |
| clears the bank selection at each time the program change is |
| submitted. This is confusing and may lead to incorrect bank values |
| tranmitted to the destination in the end. |
| |
| Drop the line to clear the bank info and keep the provided values. |
| |
| Fixes: e9e02819a98a ("ALSA: seq: Automatic conversion of UMP events") |
| Link: https://lore.kernel.org/r/20240527151852.29036-2-tiwai@suse.de |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/core/seq/seq_ump_convert.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c |
| index c21be87f5da9e..f5d22dd008426 100644 |
| --- a/sound/core/seq/seq_ump_convert.c |
| +++ b/sound/core/seq/seq_ump_convert.c |
| @@ -892,7 +892,6 @@ static int pgm_ev_to_ump_midi2(const struct snd_seq_event *event, |
| data->pg.bank_msb = cc->cc_bank_msb; |
| data->pg.bank_lsb = cc->cc_bank_lsb; |
| cc->bank_set = 0; |
| - cc->cc_bank_msb = cc->cc_bank_lsb = 0; |
| } |
| return 1; |
| } |
| -- |
| 2.43.0 |
| |
