| From 31ded341c375bb2faac1d77ab0012a732ba3e2a6 Mon Sep 17 00:00:00 2001 |
| From: Koichiro Den <den@valinux.co.jp> |
| Date: Thu, 20 Aug 2026 02:25:39 +0900 |
| Subject: net: ntb_netdev: Count packets dropped on RX refill failure |
| |
| From: Koichiro Den <den@valinux.co.jp> |
| |
| commit 31ded341c375bb2faac1d77ab0012a732ba3e2a6 upstream. |
| |
| When replacement skb allocation fails, ntb_netdev drops a packet that |
| was received successfully and requeues the original buffer. The drop is |
| counted, but rx_packets and rx_bytes are not. |
| |
| Count every good packet before allocating its replacement. |
| |
| Fixes: d2121faf133a ("NTB: ntb_netdev: Preserve RX queue depth on allocation failure") |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Koichiro Den <den@valinux.co.jp> |
| Link: https://patch.msgid.link/20260819172539.1450821-3-den@valinux.co.jp |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ntb_netdev.c | 5 +++-- |
| 1 file changed, 3 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/net/ntb_netdev.c |
| +++ b/drivers/net/ntb_netdev.c |
| @@ -115,6 +115,9 @@ static void ntb_netdev_rx_handler(struct |
| goto enqueue_again; |
| } |
| |
| + ndev->stats.rx_packets++; |
| + ndev->stats.rx_bytes += len; |
| + |
| new_skb = netdev_alloc_skb(ndev, ndev->mtu + ETH_HLEN); |
| if (!new_skb) { |
| ndev->stats.rx_dropped++; |
| @@ -126,8 +129,6 @@ static void ntb_netdev_rx_handler(struct |
| skb->ip_summed = CHECKSUM_NONE; |
| |
| netif_rx(skb); |
| - ndev->stats.rx_packets++; |
| - ndev->stats.rx_bytes += len; |
| |
| skb = new_skb; |
| |
