| From bd0abfe6b013aeb2a1aebc5fbc7ceeb50355bda3 Mon Sep 17 00:00:00 2001 |
| From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> |
| Date: Mon, 6 Jul 2026 14:44:13 +0200 |
| Subject: powerpc/powermac: fix OF node refcount |
| |
| From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> |
| |
| commit bd0abfe6b013aeb2a1aebc5fbc7ceeb50355bda3 upstream. |
| |
| Platform devices created with platform_device_alloc() call |
| platform_device_release() when the last reference to the device's |
| kobject is dropped. This function calls of_node_put() unconditionally. |
| This works fine for devices created with platform_device_register_full() |
| but users of the split approach (platform_device_alloc() + |
| platform_device_add()) must bump the reference of the of_node they |
| assign manually. Add the missing call to of_node_get(). |
| |
| Cc: stable@vger.kernel.org |
| Fixes: 81e5d8646ff6 ("i2c/powermac: Register i2c devices from device-tree") |
| Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> |
| Link: https://patch.msgid.link/20260706-pdev-fwnode-ref-v3-1-1ff028e33779@oss.qualcomm.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| arch/powerpc/platforms/powermac/low_i2c.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/arch/powerpc/platforms/powermac/low_i2c.c |
| +++ b/arch/powerpc/platforms/powermac/low_i2c.c |
| @@ -1502,7 +1502,7 @@ static int __init pmac_i2c_create_platfo |
| if (bus->platform_dev == NULL) |
| return -ENOMEM; |
| bus->platform_dev->dev.platform_data = bus; |
| - bus->platform_dev->dev.of_node = bus->busnode; |
| + bus->platform_dev->dev.of_node = of_node_get(bus->busnode); |
| platform_device_add(bus->platform_dev); |
| } |
| |
