| From 5c709b376460ff322580c41600e31c02f7cc0307 Mon Sep 17 00:00:00 2001 |
| From: Felix Gu <ustc.gu@gmail.com> |
| Date: Mon, 23 Mar 2026 00:04:08 +0800 |
| Subject: EDAC/versalnet: Fix device_node leak in mc_probe() |
| |
| From: Felix Gu <ustc.gu@gmail.com> |
| |
| commit 5c709b376460ff322580c41600e31c02f7cc0307 upstream. |
| |
| of_parse_phandle() returns a device_node reference that must be released with |
| of_node_put(). The original code never freed r5_core_node on any exit path, |
| causing a memory leak. |
| |
| Fix this by using the automatic cleanup attribute __free(device_node) which |
| ensures of_node_put() is called when the variable goes out of scope. |
| |
| Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller") |
| Signed-off-by: Felix Gu <ustc.gu@gmail.com> |
| Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> |
| Reviewed-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com> |
| Cc: <stable@kernel.org> |
| Link: https://patch.msgid.link/20260323-versalnet-v1-1-4ab3012635ef@gmail.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/edac/versalnet_edac.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/edac/versalnet_edac.c |
| +++ b/drivers/edac/versalnet_edac.c |
| @@ -868,12 +868,12 @@ static void remove_versalnet(struct mc_p |
| |
| static int mc_probe(struct platform_device *pdev) |
| { |
| - struct device_node *r5_core_node; |
| struct mc_priv *priv; |
| struct rproc *rp; |
| int rc; |
| |
| - r5_core_node = of_parse_phandle(pdev->dev.of_node, "amd,rproc", 0); |
| + struct device_node *r5_core_node __free(device_node) = |
| + of_parse_phandle(pdev->dev.of_node, "amd,rproc", 0); |
| if (!r5_core_node) { |
| dev_err(&pdev->dev, "amd,rproc: invalid phandle\n"); |
| return -EINVAL; |
