| From 1bab89d505ac77ae9f140ef849fe46442ee121fa Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 25 Jun 2025 00:05:20 +0900 |
| Subject: kconfig: gconf: avoid hardcoding model2 in |
| on_treeview2_cursor_changed() |
| |
| From: Masahiro Yamada <masahiroy@kernel.org> |
| |
| [ Upstream commit cae9cdbcd9af044810bcceeb43a87accca47c71d ] |
| |
| The on_treeview2_cursor_changed() handler is connected to both the left |
| and right tree views, but it hardcodes model2 (the GtkTreeModel of the |
| right tree view). This is incorrect. Get the associated model from the |
| view. |
| |
| Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| scripts/kconfig/gconf.c | 5 +++-- |
| 1 file changed, 3 insertions(+), 2 deletions(-) |
| |
| diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c |
| index 5d1404178e48..87f8a4db5bc6 100644 |
| --- a/scripts/kconfig/gconf.c |
| +++ b/scripts/kconfig/gconf.c |
| @@ -977,13 +977,14 @@ on_treeview2_key_press_event(GtkWidget * widget, |
| void |
| on_treeview2_cursor_changed(GtkTreeView * treeview, gpointer user_data) |
| { |
| + GtkTreeModel *model = gtk_tree_view_get_model(treeview); |
| GtkTreeSelection *selection; |
| GtkTreeIter iter; |
| struct menu *menu; |
| |
| selection = gtk_tree_view_get_selection(treeview); |
| - if (gtk_tree_selection_get_selected(selection, &model2, &iter)) { |
| - gtk_tree_model_get(model2, &iter, COL_MENU, &menu, -1); |
| + if (gtk_tree_selection_get_selected(selection, &model, &iter)) { |
| + gtk_tree_model_get(model, &iter, COL_MENU, &menu, -1); |
| text_insert_help(menu); |
| } |
| } |
| -- |
| 2.39.5 |
| |