| From 3470984373e62879275ec20e15dce99ee4f37494 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 25 Jun 2025 00:04:55 +0900 |
| Subject: kconfig: gconf: fix potential memory leak in renderer_edited() |
| |
| From: Masahiro Yamada <masahiroy@kernel.org> |
| |
| [ Upstream commit f72ed4c6a375e52a3f4b75615e4a89d29d8acea7 ] |
| |
| If gtk_tree_model_get_iter() fails, gtk_tree_path_free() is not called. |
| |
| Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> |
| Acked-by: Randy Dunlap <rdunlap@infradead.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| scripts/kconfig/gconf.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c |
| index 87f8a4db5bc6..3c726ead8f7e 100644 |
| --- a/scripts/kconfig/gconf.c |
| +++ b/scripts/kconfig/gconf.c |
| @@ -783,7 +783,7 @@ static void renderer_edited(GtkCellRendererText * cell, |
| struct symbol *sym; |
| |
| if (!gtk_tree_model_get_iter(model2, &iter, path)) |
| - return; |
| + goto free; |
| |
| gtk_tree_model_get(model2, &iter, COL_MENU, &menu, -1); |
| sym = menu->sym; |
| @@ -795,6 +795,7 @@ static void renderer_edited(GtkCellRendererText * cell, |
| |
| update_tree(&rootmenu, NULL); |
| |
| +free: |
| gtk_tree_path_free(path); |
| } |
| |
| -- |
| 2.39.5 |
| |