| From 1575253e355435cf261bc0671beddccf6d9ac4d4 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 19 Aug 2025 16:27:36 +0100 |
| Subject: cifs: Fix oops due to uninitialised variable |
| |
| From: David Howells <dhowells@redhat.com> |
| |
| [ Upstream commit 453a6d2a68e54a483d67233c6e1e24c4095ee4be ] |
| |
| Fix smb3_init_transform_rq() to initialise buffer to NULL before calling |
| netfs_alloc_folioq_buffer() as netfs assumes it can append to the buffer it |
| is given. Setting it to NULL means it should start a fresh buffer, but the |
| value is currently undefined. |
| |
| Fixes: a2906d3316fc ("cifs: Switch crypto buffer to use a folio_queue rather than an xarray") |
| Signed-off-by: David Howells <dhowells@redhat.com> |
| cc: Steve French <sfrench@samba.org> |
| cc: Paulo Alcantara <pc@manguebit.org> |
| cc: linux-cifs@vger.kernel.org |
| cc: linux-fsdevel@vger.kernel.org |
| Signed-off-by: Steve French <stfrench@microsoft.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/smb/client/smb2ops.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c |
| index 4bababee965a..ab911a967246 100644 |
| --- a/fs/smb/client/smb2ops.c |
| +++ b/fs/smb/client/smb2ops.c |
| @@ -4522,7 +4522,7 @@ smb3_init_transform_rq(struct TCP_Server_Info *server, int num_rqst, |
| for (int i = 1; i < num_rqst; i++) { |
| struct smb_rqst *old = &old_rq[i - 1]; |
| struct smb_rqst *new = &new_rq[i]; |
| - struct folio_queue *buffer; |
| + struct folio_queue *buffer = NULL; |
| size_t size = iov_iter_count(&old->rq_iter); |
| |
| orig_len += smb_rqst_len(server, old); |
| -- |
| 2.50.1 |
| |
