| From 5b10916ea0a62920204517e1c4ce14560b4f96ab Mon Sep 17 00:00:00 2001 |
| From: Greg Kroah-Hartman <gregkh@suse.de> |
| Date: Tue, 10 Mar 2009 20:42:55 -0700 |
| Subject: USB: usbtmc: fix stupid bug in open() |
| |
| From: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| commit 5b10916ea0a62920204517e1c4ce14560b4f96ab upstream. |
| |
| open() will never succeed, as we always return -ENODEV. Fix this |
| obvious bug. |
| |
| Thanks to Jouni Ryno for reporting it. |
| |
| Reported-by: Jouni Ryno <Jouni.Ryno@fmi.fi> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/usb/class/usbtmc.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/usb/class/usbtmc.c |
| +++ b/drivers/usb/class/usbtmc.c |
| @@ -105,12 +105,13 @@ static int usbtmc_open(struct inode *ino |
| { |
| struct usb_interface *intf; |
| struct usbtmc_device_data *data; |
| - int retval = -ENODEV; |
| + int retval = 0; |
| |
| intf = usb_find_interface(&usbtmc_driver, iminor(inode)); |
| if (!intf) { |
| printk(KERN_ERR KBUILD_MODNAME |
| ": can not find device for minor %d", iminor(inode)); |
| + retval = -ENODEV; |
| goto exit; |
| } |
| |
