| From f9287c1f2d329f4d78a3bbc9cf0db0ebae6f146a Mon Sep 17 00:00:00 2001 |
| From: "Darrick J. Wong" <djwong@us.ibm.com> |
| Date: Wed, 31 Aug 2011 12:00:51 -0400 |
| Subject: ext4: ext4_mkdir should dirty dir_block with newly created directory inode |
| |
| From: "Darrick J. Wong" <djwong@us.ibm.com> |
| |
| commit f9287c1f2d329f4d78a3bbc9cf0db0ebae6f146a upstream. |
| |
| ext4_mkdir calls ext4_handle_dirty_metadata with dir_block and the inode "dir". |
| Unfortunately, dir_block belongs to the newly created directory (which is |
| "inode"), not the parent directory (which is "dir"). Fix the incorrect |
| association. |
| |
| Signed-off-by: Darrick J. Wong <djwong@us.ibm.com> |
| Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| fs/ext4/namei.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/ext4/namei.c |
| +++ b/fs/ext4/namei.c |
| @@ -1863,7 +1863,7 @@ retry: |
| ext4_set_de_type(dir->i_sb, de, S_IFDIR); |
| inode->i_nlink = 2; |
| BUFFER_TRACE(dir_block, "call ext4_handle_dirty_metadata"); |
| - err = ext4_handle_dirty_metadata(handle, dir, dir_block); |
| + err = ext4_handle_dirty_metadata(handle, inode, dir_block); |
| if (err) |
| goto out_clear_inode; |
| err = ext4_mark_inode_dirty(handle, inode); |
