| From 68693b8ea4e284c46bff919ac62bd9ccdfdbb6ba Mon Sep 17 00:00:00 2001 |
| From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> |
| Date: Thu, 11 Dec 2014 18:14:18 +0100 |
| Subject: usb: musb: stuff leak of struct usb_hcd |
| |
| From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> |
| |
| commit 68693b8ea4e284c46bff919ac62bd9ccdfdbb6ba upstream. |
| |
| since the split of host+gadget mode in commit 74c2e9360058 ("usb: musb: |
| factor out hcd initalization") we leak the usb_hcd struct. We call now |
| musb_host_cleanup() which does basically usb_remove_hcd() and also sets |
| the hcd variable to NULL. Doing so makes the finall call to |
| musb_host_free() basically a nop and the usb_hcd remains around for ever |
| without anowner. |
| This patch drops that NULL assignment for that reason. |
| |
| Fixes: 74c2e9360058 ("usb: musb: factor out hcd initalization") |
| Cc: Daniel Mack <zonque@gmail.com> |
| Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> |
| Signed-off-by: Felipe Balbi <balbi@ti.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/musb/musb_host.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| --- a/drivers/usb/musb/musb_host.c |
| +++ b/drivers/usb/musb/musb_host.c |
| @@ -2663,7 +2663,6 @@ void musb_host_cleanup(struct musb *musb |
| if (musb->port_mode == MUSB_PORT_MODE_GADGET) |
| return; |
| usb_remove_hcd(musb->hcd); |
| - musb->hcd = NULL; |
| } |
| |
| void musb_host_free(struct musb *musb) |
