| From ea5f4db8ece896c2ab9eafa0924148a2596c52e4 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Sat, 3 Mar 2012 12:09:17 +0100 |
| Subject: block, sx8: fix pointer math issue getting fw version |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit ea5f4db8ece896c2ab9eafa0924148a2596c52e4 upstream. |
| |
| "mem" is type u8. We need parenthesis here or it screws up the pointer |
| math probably leading to an oops. |
| |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Acked-by: Jeff Garzik <jgarzik@redhat.com> |
| Signed-off-by: Jens Axboe <axboe@kernel.dk> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/block/sx8.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/block/sx8.c |
| +++ b/drivers/block/sx8.c |
| @@ -1116,7 +1116,7 @@ static inline void carm_handle_resp(stru |
| break; |
| case MISC_GET_FW_VER: { |
| struct carm_fw_ver *ver = (struct carm_fw_ver *) |
| - mem + sizeof(struct carm_msg_get_fw_ver); |
| + (mem + sizeof(struct carm_msg_get_fw_ver)); |
| if (!error) { |
| host->fw_ver = le32_to_cpu(ver->version); |
| host->flags |= (ver->features & FL_FW_VER_MASK); |
