| From bd0f2e6da7ea9e225cb2dbd3229e25584b0e9538 Mon Sep 17 00:00:00 2001 |
| From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| Date: Fri, 11 Nov 2011 11:22:20 -0300 |
| Subject: [media] omap3isp: ccdc: Fix crash in HS/VS interrupt handler |
| |
| From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| |
| commit bd0f2e6da7ea9e225cb2dbd3229e25584b0e9538 upstream. |
| |
| The HS/VS interrupt handler needs to access the pipeline object. It |
| erronously tries to get it from the CCDC output video node, which isn't |
| necessarily included in the pipeline. This leads to a NULL pointer |
| dereference. |
| |
| Fix the bug by getting the pipeline object from the CCDC subdev entity. |
| |
| Reported-by: Gary Thomas <gary@mlbassoc.com> |
| Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| Acked-by: Sakari Ailus <sakari.ailus@iki.fi> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/media/video/omap3isp/ispccdc.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| --- a/drivers/media/video/omap3isp/ispccdc.c |
| +++ b/drivers/media/video/omap3isp/ispccdc.c |
| @@ -1406,8 +1406,7 @@ static int __ccdc_handle_stopping(struct |
| |
| static void ccdc_hs_vs_isr(struct isp_ccdc_device *ccdc) |
| { |
| - struct isp_pipeline *pipe = |
| - to_isp_pipeline(&ccdc->video_out.video.entity); |
| + struct isp_pipeline *pipe = to_isp_pipeline(&ccdc->subdev.entity); |
| struct video_device *vdev = ccdc->subdev.devnode; |
| struct v4l2_event event; |
| |
