| From fbbf8555a986ed31e54f006b6cc637ea4ff1425b Mon Sep 17 00:00:00 2001 |
| From: Nicholas Bellinger <nab@linux-iscsi.org> |
| Date: Mon, 18 Feb 2013 18:31:37 -0800 |
| Subject: target: Add missing mapped_lun bounds checking during make_mappedlun setup |
| |
| From: Nicholas Bellinger <nab@linux-iscsi.org> |
| |
| commit fbbf8555a986ed31e54f006b6cc637ea4ff1425b upstream. |
| |
| This patch adds missing bounds checking for the configfs provided |
| mapped_lun value during target_fabric_make_mappedlun() setup ahead |
| of se_lun_acl initialization. |
| |
| This addresses a potential OOPs when using a mapped_lun value that |
| exceeds the hardcoded TRANSPORT_MAX_LUNS_PER_TPG-1 value within |
| se_node_acl->device_list[]. |
| |
| Reported-by: Jan Engelhardt <jengelh@inai.de> |
| Cc: Jan Engelhardt <jengelh@inai.de> |
| Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/target/target_core_fabric_configfs.c | 8 ++++++++ |
| 1 file changed, 8 insertions(+) |
| |
| --- a/drivers/target/target_core_fabric_configfs.c |
| +++ b/drivers/target/target_core_fabric_configfs.c |
| @@ -356,6 +356,14 @@ static struct config_group *target_fabri |
| ret = -EINVAL; |
| goto out; |
| } |
| + if (mapped_lun > (TRANSPORT_MAX_LUNS_PER_TPG-1)) { |
| + pr_err("Mapped LUN: %lu exceeds TRANSPORT_MAX_LUNS_PER_TPG" |
| + "-1: %u for Target Portal Group: %u\n", mapped_lun, |
| + TRANSPORT_MAX_LUNS_PER_TPG-1, |
| + se_tpg->se_tpg_tfo->tpg_get_tag(se_tpg)); |
| + ret = -EINVAL; |
| + goto out; |
| + } |
| |
| lacl = core_dev_init_initiator_node_lun_acl(se_tpg, se_nacl, |
| mapped_lun, &ret); |
