| From foo@baz Sun 09 Feb 2020 10:56:46 PM CET |
| From: Raed Salem <raeds@mellanox.com> |
| Date: Tue, 24 Dec 2019 09:54:45 +0200 |
| Subject: net/mlx5: IPsec, Fix esp modify function attribute |
| |
| From: Raed Salem <raeds@mellanox.com> |
| |
| [ Upstream commit 0dc2c534f17c05bed0622b37a744bc38b48ca88a ] |
| |
| The function mlx5_fpga_esp_validate_xfrm_attrs is wrongly used |
| with negative negation as zero value indicates success but it |
| used as failure return value instead. |
| |
| Fix by remove the unary not negation operator. |
| |
| Fixes: 05564d0ae075 ("net/mlx5: Add flow-steering commands for FPGA IPSec implementation") |
| Signed-off-by: Raed Salem <raeds@mellanox.com> |
| Reviewed-by: Boris Pismenny <borisp@mellanox.com> |
| Signed-off-by: Saeed Mahameed <saeedm@mellanox.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c |
| +++ b/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c |
| @@ -1472,7 +1472,7 @@ int mlx5_fpga_esp_modify_xfrm(struct mlx |
| if (!memcmp(&xfrm->attrs, attrs, sizeof(xfrm->attrs))) |
| return 0; |
| |
| - if (!mlx5_fpga_esp_validate_xfrm_attrs(mdev, attrs)) { |
| + if (mlx5_fpga_esp_validate_xfrm_attrs(mdev, attrs)) { |
| mlx5_core_warn(mdev, "Tried to create an esp with unsupported attrs\n"); |
| return -EOPNOTSUPP; |
| } |
