| From foo@baz Sun 09 Feb 2020 10:56:46 PM CET |
| From: Florian Fainelli <f.fainelli@gmail.com> |
| Date: Wed, 5 Feb 2020 12:32:04 -0800 |
| Subject: net: systemport: Avoid RBUF stuck in Wake-on-LAN mode |
| |
| From: Florian Fainelli <f.fainelli@gmail.com> |
| |
| [ Upstream commit 263a425a482fc495d6d3f9a29b9103a664c38b69 ] |
| |
| After a number of suspend and resume cycles, it is possible for the RBUF |
| to be stuck in Wake-on-LAN mode, despite the MPD enable bit being |
| cleared which instructed the RBUF to exit that mode. |
| |
| Avoid creating that problematic condition by clearing the RX_EN and |
| TX_EN bits in the UniMAC prior to disable the Magic Packet Detector |
| logic which is guaranteed to make the RBUF exit Wake-on-LAN mode. |
| |
| Fixes: 83e82f4c706b ("net: systemport: add Wake-on-LAN support") |
| Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/broadcom/bcmsysport.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| --- a/drivers/net/ethernet/broadcom/bcmsysport.c |
| +++ b/drivers/net/ethernet/broadcom/bcmsysport.c |
| @@ -2716,6 +2716,9 @@ static int __maybe_unused bcm_sysport_re |
| |
| umac_reset(priv); |
| |
| + /* Disable the UniMAC RX/TX */ |
| + umac_enable_set(priv, CMD_RX_EN | CMD_TX_EN, 0); |
| + |
| /* We may have been suspended and never received a WOL event that |
| * would turn off MPD detection, take care of that now |
| */ |
