| From 526f3d96b8f83b1b13d73bd0b5c79cc2c487ec8e Mon Sep 17 00:00:00 2001 |
| From: Jiri Slaby <jslaby@suse.cz> |
| Date: Mon, 20 Apr 2020 09:04:24 +0200 |
| Subject: cgroup, netclassid: remove double cond_resched |
| |
| From: Jiri Slaby <jslaby@suse.cz> |
| |
| commit 526f3d96b8f83b1b13d73bd0b5c79cc2c487ec8e upstream. |
| |
| Commit 018d26fcd12a ("cgroup, netclassid: periodically release file_lock |
| on classid") added a second cond_resched to write_classid indirectly by |
| update_classid_task. Remove the one in write_classid. |
| |
| Signed-off-by: Jiri Slaby <jslaby@suse.cz> |
| Cc: Dmitry Yakunin <zeil@yandex-team.ru> |
| Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> |
| Cc: David S. Miller <davem@davemloft.net> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| net/core/netclassid_cgroup.c | 4 +--- |
| 1 file changed, 1 insertion(+), 3 deletions(-) |
| |
| --- a/net/core/netclassid_cgroup.c |
| +++ b/net/core/netclassid_cgroup.c |
| @@ -131,10 +131,8 @@ static int write_classid(struct cgroup_s |
| cs->classid = (u32)value; |
| |
| css_task_iter_start(css, 0, &it); |
| - while ((p = css_task_iter_next(&it))) { |
| + while ((p = css_task_iter_next(&it))) |
| update_classid_task(p, cs->classid); |
| - cond_resched(); |
| - } |
| css_task_iter_end(&it); |
| |
| return 0; |