| From f2bc8b1971a40899d35d82eab1df1aef9a81cc9b Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 11 Sep 2021 15:50:23 +0800 |
| Subject: drm/nouveau/debugfs: fix file release memory leak |
| |
| From: Yang Yingliang <yangyingliang@huawei.com> |
| |
| [ Upstream commit f5a8703a9c418c6fc54eb772712dfe7641e3991c ] |
| |
| When using single_open() for opening, single_release() should be |
| called, otherwise the 'op' allocated in single_open() will be leaked. |
| |
| Fixes: 6e9fc177399f ("drm/nouveau/debugfs: add copy of sysfs pstate interface ported to debugfs") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> |
| Reviewed-by: Karol Herbst <kherbst@redhat.com> |
| Signed-off-by: Karol Herbst <kherbst@redhat.com> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20210911075023.3969054-2-yangyingliang@huawei.com |
| Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/nouveau/nouveau_debugfs.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c |
| index 4561a786fab0..cce4833a6083 100644 |
| --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c |
| +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c |
| @@ -185,6 +185,7 @@ static const struct file_operations nouveau_pstate_fops = { |
| .open = nouveau_debugfs_pstate_open, |
| .read = seq_read, |
| .write = nouveau_debugfs_pstate_set, |
| + .release = single_release, |
| }; |
| |
| static struct drm_info_list nouveau_debugfs_list[] = { |
| -- |
| 2.33.0 |
| |
