| From acf8dc50b61bf98deafb6da7d4f62a16a694e964 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 24 Jan 2022 13:13:46 +0000 |
| Subject: power: supply: ab8500: Fix memory leak in ab8500_fg_sysfs_init |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Miaoqian Lin <linmq006@gmail.com> |
| |
| [ Upstream commit 6a4760463dbc6b603690938c468839985189ce0a ] |
| |
| kobject_init_and_add() takes reference even when it fails. |
| According to the doc of kobject_init_and_add()： |
| |
| If this function returns an error, kobject_put() must be called to |
| properly clean up the memory associated with the object. |
| |
| Fix memory leak by calling kobject_put(). |
| |
| Fixes: 8c0984e5a753 ("power: move power supply drivers to power/supply") |
| Signed-off-by: Miaoqian Lin <linmq006@gmail.com> |
| Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/power/supply/ab8500_fg.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c |
| index b0e77324b016..675f9d0e8471 100644 |
| --- a/drivers/power/supply/ab8500_fg.c |
| +++ b/drivers/power/supply/ab8500_fg.c |
| @@ -2541,8 +2541,10 @@ static int ab8500_fg_sysfs_init(struct ab8500_fg *di) |
| ret = kobject_init_and_add(&di->fg_kobject, |
| &ab8500_fg_ktype, |
| NULL, "battery"); |
| - if (ret < 0) |
| + if (ret < 0) { |
| + kobject_put(&di->fg_kobject); |
| dev_err(di->dev, "failed to create sysfs entry\n"); |
| + } |
| |
| return ret; |
| } |
| -- |
| 2.34.1 |
| |
