| From fe503887eed6ea528e144ec8dacfa1d47aa701ac Mon Sep 17 00:00:00 2001 |
| From: Miaoqian Lin <linmq006@gmail.com> |
| Date: Fri, 29 Apr 2022 17:49:17 +0100 |
| Subject: slimbus: qcom: Fix IRQ check in qcom_slim_probe |
| |
| From: Miaoqian Lin <linmq006@gmail.com> |
| |
| commit fe503887eed6ea528e144ec8dacfa1d47aa701ac upstream. |
| |
| platform_get_irq() returns non-zero IRQ number on success, |
| negative error number on failure. |
| And the doc of platform_get_irq() provides a usage example: |
| |
| int irq = platform_get_irq(pdev, 0); |
| if (irq < 0) |
| return irq; |
| |
| Fix the check of return value to catch errors correctly. |
| |
| Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver") |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Miaoqian Lin <linmq006@gmail.com> |
| Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
| Link: https://lore.kernel.org/r/20220429164917.5202-2-srinivas.kandagatla@linaro.org |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/slimbus/qcom-ctrl.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/slimbus/qcom-ctrl.c |
| +++ b/drivers/slimbus/qcom-ctrl.c |
| @@ -515,9 +515,9 @@ static int qcom_slim_probe(struct platfo |
| } |
| |
| ctrl->irq = platform_get_irq(pdev, 0); |
| - if (!ctrl->irq) { |
| + if (ctrl->irq < 0) { |
| dev_err(&pdev->dev, "no slimbus IRQ\n"); |
| - return -ENODEV; |
| + return ctrl->irq; |
| } |
| |
| sctrl = &ctrl->ctrl; |
